From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T1Ngi-0000rH-24
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 16:26:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T1Ngg-0008Ec-Pt
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 16:26:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24100)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T1Ngg-0008E0-Gx
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 16:26:02 -0400
Date: Tue, 14 Aug 2012 17:26:42 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120814172642.025662b7@doriath.home>
In-Reply-To: <87ipcls1f6.fsf@codemonkey.ws>
References: <1344951151-26387-1-git-send-email-aliguori@us.ibm.com>
	<20120814114940.68c296c7@doriath.home>
	<87ipcls1f6.fsf@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration
 for the 1.2 release
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On Tue, 14 Aug 2012 14:45:17 -0500
Anthony Liguori <aliguori@us.ibm.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Tue, 14 Aug 2012 08:32:31 -0500
> > Anthony Liguori <aliguori@us.ibm.com> wrote:
> >
> >> To be replaced with live block copy.
> >> 
> >> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> >> ---
> >>  migration.c |    9 +++++++++
> >>  1 files changed, 9 insertions(+), 0 deletions(-)
> >> 
> >> diff --git a/migration.c b/migration.c
> >> index 653a3c1..babccf4 100644
> >> --- a/migration.c
> >> +++ b/migration.c
> >> @@ -482,10 +482,19 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
> >>      MigrationParams params;
> >>      const char *p;
> >>      int ret;
> >> +    static bool suppress_deprecation_message;
> >>  
> >>      params.blk = blk;
> >>      params.shared = inc;
> >>  
> >> +    if (blk && !suppress_deprecation_message) {
> >> +        qerror_report(ERROR_CLASS_GENERIC_ERROR,
> >> +                      "Block migration is deprecated.  "
> >> +                      "See http://wiki.qemu.org/Features/LiveBlockCopy "
> >> +                      "for an alternative syntax.");
> >
> > Why not error_set()?
> 
> Because we fall through (we don't fail).  This is just a warning.
> 
> If you error_set(), then the migration command fails.  We don't want it
> to fail.
> 
> I guess qerror_report will do that too :-(
> 
> I'll change it to an fprintf :-((

Yes, I'd also add a monitor_printf() call to hmp_migrate() and a note to
the schema.