From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1S3w-0000YA-UB for qemu-devel@nongnu.org; Tue, 14 Aug 2012 21:06:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1S3v-0001nG-Bl for qemu-devel@nongnu.org; Tue, 14 Aug 2012 21:06:20 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:60402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1S3u-0001lh-Pd for qemu-devel@nongnu.org; Tue, 14 Aug 2012 21:06:19 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 Aug 2012 11:05:08 +1000 Date: Wed, 15 Aug 2012 11:03:11 +1000 From: David Gibson Message-ID: <20120815010311.GD8136@truffula.fritz.box> References: <1344391839-2006-1-git-send-email-david@gibson.dropbear.id.au> <1344391839-2006-7-git-send-email-david@gibson.dropbear.id.au> <502A3A71.20908@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <502A3A71.20908@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/10] pseries: Export find_phb() utility function for PCI code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: aliguori@us.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Tue, Aug 14, 2012 at 01:45:53PM +0200, Alexander Graf wrote: > On 08/08/2012 04:10 AM, David Gibson wrote: > >From: Alexey Kardashevskiy > > > >The pseries PCI code makes use of an internal find_dev() function which > >locates a PCIDevice * given a (platform specific) bus ID and device > >address. Internally this needs to first locate the host bridge on which > >the device resides based on the bus ID. This patch exposes that host > >bridge lookup as a separate function, which we will need later in the MSI > >and VFIO code. > > > >Signed-off-by: Alexey Kardashevskiy > >Signed-off-by: David Gibson > >--- > > hw/spapr_pci.c | 32 ++++++++++++++++++++++---------- > > 1 file changed, 22 insertions(+), 10 deletions(-) > > > >diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c > >index fcc358e..842068f 100644 > >--- a/hw/spapr_pci.c > >+++ b/hw/spapr_pci.c > >@@ -29,27 +29,39 @@ > > #include "hw/spapr_pci.h" > > #include "exec-memory.h" > > #include > >+#include "trace.h" > > trace.h? Sorry, probably leaked in from an earlier version or related patch which did actually add some trace point calls. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson