From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: kwolf@redhat.com, "Benoît Canet" <benoit@irqsave.net>,
qemu-devel@nongnu.org, blauwirbel@gmail.com,
anthony@codemonkey.ws, pbonzini@redhat.com, eblake@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC V3 9/9] quorum: Add quorum mechanism.
Date: Wed, 15 Aug 2012 11:51:32 +0100 [thread overview]
Message-ID: <20120815105132.GG27481@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1344953651-16622-10-git-send-email-benoit@irqsave.net>
On Tue, Aug 14, 2012 at 04:14:11PM +0200, Benoît Canet wrote:
> +#define QUORUM_FREE_QIOV_ITEMS(qlist) do { \
> + QLIST_FOREACH_SAFE(item, qlist, next, next_item) { \
> + QLIST_REMOVE(item, next); \
> + g_free(item); \
> + } } while (0)
This is only used once, please open code it and don't use a macro.
> +
> +static void quorum_free_vote_list(QuorumAIOCB *acb)
> +{
> + QuorumIOVectorVersion *version, *next_version;
> + QuorumIOVectorItem *item, *next_item;
> +
> + QLIST_FOREACH_SAFE(version, &acb->vote_list, next, next_version) {
> + QLIST_REMOVE(version, next);
> + QUORUM_FREE_QIOV_ITEMS(&version->qiov_items);
> + g_free(version);
> + }
> +}
> +
> +#undef QUORUM_FREE_QIOV_ITEMS
next prev parent reply other threads:[~2012-08-15 10:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 14:14 [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 1/9] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 3/9] quorum: Add quorum_open() and quorum_close() Benoît Canet
2012-08-14 14:45 ` Eric Blake
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength() Benoît Canet
2012-08-14 16:08 ` Eric Blake
2012-08-16 13:18 ` Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 5/9] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 6/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 7/9] quorum: Add quorum_co_flush() Benoît Canet
2012-08-14 18:52 ` Blue Swirl
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 8/9] quorum: Add quorum_aio_readv Benoît Canet
2012-08-15 10:53 ` Stefan Hajnoczi
2012-08-14 14:14 ` [Qemu-devel] [RFC V3 9/9] quorum: Add quorum mechanism Benoît Canet
2012-08-15 10:51 ` Stefan Hajnoczi [this message]
2012-08-14 18:47 ` [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency Blue Swirl
2012-08-15 13:12 ` Stefan Hajnoczi
2012-08-20 10:12 ` Benoît Canet
2012-08-20 11:23 ` Stefan Hajnoczi
2012-08-20 11:24 ` Stefan Hajnoczi
2012-08-20 11:42 ` Benoît Canet
2012-08-20 12:56 ` Stefan Hajnoczi
2012-08-20 14:03 ` Benoît Canet
2012-08-20 15:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815105132.GG27481@stefanha-thinkpad.localdomain \
--to=stefanha@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=benoit.canet@gmail.com \
--cc=benoit@irqsave.net \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).