qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] vnc: Improve comment
Date: Wed, 15 Aug 2012 14:48:27 +0100	[thread overview]
Message-ID: <20120815134827.GG10742@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1344628293-4565-1-git-send-email-sw@weilnetz.de>

On Fri, Aug 10, 2012 at 09:51:33PM +0200, Stefan Weil wrote:
> It's still not good, but hopefully better than before.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  ui/vnc-enc-zywrle.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h
> index 188e247..addee55 100644
> --- a/ui/vnc-enc-zywrle.h
> +++ b/ui/vnc-enc-zywrle.h
> @@ -305,8 +305,8 @@ static inline void harr(int8_t *px0, int8_t *px1)
>     |L1H0H1H0|L1H0H1H0|L1H0H1H0|L1H0H1H0| : level 1
>  
>   In this method, H/L and X0/X1 is always same position.
> - This lead us to more speed and less memory.
> - Of cause, the result of both methods is quite same
> + This leads us to more speed and less memory.
> + Of course, the result of both methods is quite same
>   because its only difference is that coefficient position.
>  */
>  static inline void wavelet_level(int *data, int size, int l, int skip_pixel)

I would drop this patch since this file seems to be copied from an
external project and not customized for QEMU:

"THIS FILE IS PART OF THE 'ZYWRLE' VNC CODEC SOURCE CODE."

If we need to sync to a newer version in the future, the spelling fixes
just add diff noise.

Stefan

      reply	other threads:[~2012-08-15 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 19:51 [Qemu-devel] [PATCH] vnc: Improve comment Stefan Weil
2012-08-15 13:48 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120815134827.GG10742@stefanha-thinkpad.localdomain \
    --to=stefanha@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).