From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T1gpV-0003Dv-31
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:52:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T1gpT-0007CK-O6
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:52:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47250)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T1gpT-0007CE-Gi
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:52:23 -0400
Date: Wed, 15 Aug 2012 13:53:02 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120815135302.3c2cc4da@doriath.home>
In-Reply-To: <502B3CBD.9060709@weilnetz.de>
References: <1344614655-2195-1-git-send-email-aliguori@us.ibm.com>
	<20120813141658.1bc8b15e@doriath.home>
	<502B3CBD.9060709@weilnetz.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need
 (v2)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Eric Blake <eblake@redhat.com>

On Wed, 15 Aug 2012 08:07:57 +0200
Stefan Weil <sw@weilnetz.de> wrote:

> Am 13.08.2012 19:16, schrieb Luiz Capitulino:
> > On Fri, 10 Aug 2012 11:04:08 -0500
> > Anthony Liguori <aliguori@us.ibm.com> wrote:
> >
> >> This series implements the necessary commands to implements danpb's idea to
> >> remove -help parsing in libvirt.  We would introduce all of these commands in
> >> 1.2 and then change the -help output starting in 1.3.
> >
> > Applied to the qmp branch, thanks.
> >
> 
> 
> The series breaks cross compilation of QEMU for w32 on Debian Linux:
> 
>    LINK  arm-softmmu/qemu-system-armw.exe
> ../qmp-marshal.o: In function `qmp_marshal_input_query_cpu_definitions':
> /home/stefan/w32/qmp-marshal.c:2585: undefined reference to 
> `_qmp_query_cpu_definitions'

Does this patch fix it?

 http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg02676.html

> 
> Weak symbols obviously use a different name mangling, therefore 
> qmp_query_cpu_definitions
> is not found by the linker.
> 
> Adding GCC_WEAK to the declaration of qmp_query_cpu_definitions in 
> generated file
> qmp-commands.h fixes that.
> 
> Regards,
> 
> Stefan Weil
>