From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T1i6k-0005pt-JP
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:14:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T1i6i-00088B-SB
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:14:18 -0400
Received: from paradis.irqsave.net ([109.190.18.76]:35917)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T1i6i-00087g-Jc
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:14:16 -0400
Date: Wed, 15 Aug 2012 20:14:08 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20120815181408.GA20270@irqsave.net>
References: <1345042466-31743-1-git-send-email-benoit@irqsave.net>
	<1345042466-31743-2-git-send-email-benoit@irqsave.net>
	<502BE4C8.7060601@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <502BE4C8.7060601@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@gmail.com>, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com

Le Wednesday 15 Aug 2012 =E0 12:04:56 (-0600), Eric Blake a =E9crit :
> On 08/15/2012 08:54 AM, Beno=EEt Canet wrote:
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > ---
> >  qapi-schema.json |   24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >=20
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index a92adb1..8d4df19 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -126,6 +126,30 @@
> >              'running', 'save-vm', 'shutdown', 'suspended', 'watchdog=
' ] }
> > =20
> >  ##
> > +# @SnapshotInfo
> > +#
> > +# @id: unique snapshot id
> > +#
> > +# @name: user choosen name
> > +#
> > +# @vm-state-size: size of the VM state
> > +#
> > +# @date-sec: UTC date of the snapshot
> > +#
> > +# @date-nsec: date in nano seconds
>=20
I took all the availables fields:

typedef struct QEMUSnapshotInfo {
    char id_str[128]; /* unique snapshot id */
    /* the following fields are informative. They are not needed for
       the consistency of the snapshot */
    char name[256]; /* user chosen name */
    uint64_t vm_state_size; /* VM state info size */
    uint32_t date_sec; /* UTC date of the snapshot */
    uint32_t date_nsec;
    uint64_t vm_clock_nsec; /* VM clock relative to boot */
} QEMUSnapshotInfo;


> How come we track a subsecond creation time,
>=20
> > +#
> > +# @vm-clock-sec: VM clock relative to boot
>=20
> but not a subsecond relative time for the VM clock?  Is that additional
> precision available for querying?

This one is vm-clock-nsec I made a typo


>=20
> I have no problem if you want to squash patches 1 and 2 together into a
> single commit.
ok

Beno=EEt

>=20
> --=20
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20