From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56329)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1T1iau-0006hG-Au
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:45:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1T1iat-0000zw-6Q
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:45:28 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:49691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1T1iat-0000zq-1x
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 14:45:27 -0400
Received: by yenm4 with SMTP id m4so2133328yen.4
	for <qemu-devel@nongnu.org>; Wed, 15 Aug 2012 11:45:26 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 15 Aug 2012 13:44:58 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120815184458.GF2941@illuin>
References: <1345053420-29974-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1345053420-29974-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<502BE5C5.9010503@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <502BE5C5.9010503@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-1.2 v2 2/3] json-parser: don't
 replicate tokens at each level of recursion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Wed, Aug 15, 2012 at 12:09:09PM -0600, Eric Blake wrote:
> On 08/15/2012 11:56 AM, Michael Roth wrote:
> > Currently, when parsing a stream of tokens we make a copy of the token
> > list at the beginning of each level of recursion so that we do not
> > modify the original list in cases where we need to fall back to an
> > earlier state.
> > 
> > +
> > +/* Note: parser_context_{peek|pop}_token do not increment the
> > + * token object's refcount. In both cases the references will continue
> > + * to be * tracked and cleanup in parser_context_free()
> 
> Bad comment reflow? s/be * tracked/be tracked/
> 
> > +
> > +/* to support error propagation, ctxt->err must be freed seperately */
> 
> s/seperately/separately/
> 

Thanks, fixed in incoming v3

> -- 
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>