From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Tnb-0006v3-MC for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:21:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3TnX-0005A6-Oa for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:21:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3TnX-00059u-H9 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:21:47 -0400 Date: Mon, 20 Aug 2012 12:22:10 -0300 From: Luiz Capitulino Message-ID: <20120820122210.572a79b5@doriath.home> In-Reply-To: <1345419579-25499-4-git-send-email-imammedo@redhat.com> References: <1345419579-25499-1-git-send-email-imammedo@redhat.com> <1345419579-25499-4-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include qemu-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com, avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com, sw@weilnetz.de, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Mon, 20 Aug 2012 01:39:37 +0200 Igor Mammedov wrote: > needed to prevent build breakage when CPU becomes a child of DeviceState > > Signed-off-by: Igor Mammedov > --- > scripts/qapi-types.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py > index cf601ae..f34addb 100644 > --- a/scripts/qapi-types.py > +++ b/scripts/qapi-types.py > @@ -263,7 +263,7 @@ fdecl.write(mcgen(''' > #ifndef %(guard)s > #define %(guard)s > > -#include "qemu-common.h" > +#include Please, also include , as int64_t is used in qapi-types.h. The build doesn't break probably because files including qapi-types.h are including first. > > ''', > guard=guardname(h_file)))