From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Qgy-0004Bb-UO for qemu-devel@nongnu.org; Mon, 20 Aug 2012 08:02:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Qgx-0008OS-Jd for qemu-devel@nongnu.org; Mon, 20 Aug 2012 08:02:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Qgx-0008OE-8T for qemu-devel@nongnu.org; Mon, 20 Aug 2012 08:02:47 -0400 Date: Mon, 20 Aug 2012 14:02:26 +0200 From: Igor Mammedov Message-ID: <20120820140226.568ce6c5@thinkpad.mammed.net> In-Reply-To: <1345226022-21654-1-git-send-email-ehabkost@redhat.com> References: <1345226022-21654-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/6] i386: CPU: remove duplicate feature names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, afaerber@suse.de On Fri, 17 Aug 2012 14:53:36 -0300 Eduardo Habkost wrote: > The problem: > > - Some features are report at the same time on both CPUID[1].EDX and > CPUID[8000_0001].EDX on AMD CPUs (e.g. fpu, tsc, msr, pae, mmx). > - "-cpu ,+feature" should enable the bit only on CPUID[1] if > it's not an AMD CPU, but it should enable the bit on both CPUID[1] and > CPUID[8000_0001] if it's an AMD CPU. > - The same should happen when implementing CPU properties: setting the > property that enables a feature should set the duplicate CPUID[8000_0001].EDX > bit only if CPU vendor is AMD. > > Reference: http://article.gmane.org/gmane.comp.emulators.qemu/166024 > > The solution implemented by this series is: > - On the CPU model table and while parsing CPU options/properties, set the bit > only on CPUID[1] (the x86_def_t.features field). > - When finishing initialization of the CPU cpuid fields, duplicate those > feature bits on cpuid_ext2_features if and only if the CPU vendor is AMD. > > This series also removes the "cpudef" config support, to make this work easier > (because the cpudef interface is based on low-level CPUID leaf+register > specification, instead of a set of higher-level per-feature object properties). > > Eduardo Habkost (6): > x86_cpudef_setup: coding style change > i386: kill cpudef config section support > i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved > i386: kvm: use a #define for the set of alias feature bits > i386: cpu: eliminate duplicate feature names above 3 patches should go before cpu properties > i386: -cpu help: remove reference to specific CPUID leaves/registers > > target-i386/cpu.c | 153 +++++++++++++----------------------------------------- > target-i386/cpu.h | 12 +++++ > target-i386/kvm.c | 2 +- > 3 files changed, 50 insertions(+), 117 deletions(-) > > -- > 1.7.11.2 > > -- Regards, Igor