From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T3YBb-0002cE-8n
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 16:02:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T3YBa-0003Df-Bb
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 16:02:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T3YBa-0003DX-46
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 16:02:54 -0400
Date: Mon, 20 Aug 2012 17:03:36 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120820170336.7f47f9f2@doriath.home>
In-Reply-To: <CAAu8pHsLrpqBRez51Pby5SyFX+9Fg21mxz_rpT7zLjcW2V__-g@mail.gmail.com>
References: <ece862b13efaa4c37f9e46493eb9920807869ab1.1345320875.git.blauwirbel@gmail.com>
	<20120820120810.48d7e72a@doriath.home>
	<CAAu8pHsLrpqBRez51Pby5SyFX+9Fg21mxz_rpT7zLjcW2V__-g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Mon, 20 Aug 2012 19:55:10 +0000
Blue Swirl <blauwirbel@gmail.com> wrote:

> On Mon, Aug 20, 2012 at 3:08 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > On Sat, 18 Aug 2012 20:14:54 +0000
> > Blue Swirl <blauwirbel@gmail.com> wrote:
> >
> >> Some variables are only used on !win32, declare
> >> them only when used.
> >>
> >> This avoids a warning in mingw32 build:
> >>   CC    i386-softmmu/monitor.o
> >> /src/qemu/monitor.c: In function 'monitor_fdset_get_fd':
> >> /src/qemu/monitor.c:2575: warning: unused variable 'mon_fd_flags'
> >> /src/qemu/monitor.c:2574: warning: unused variable 'mon_fdset_fd'
> >> /src/qemu/monitor.c:2573: warning: unused variable 'mon_fdset'
> >>
> >> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> >
> > Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
> >
> > Do you want this to go through my tree or will you apply it directly?
> 
> I'd like to get this to 1.2, so if you don't have anything in queue, I
> can apply directly.

I have a queue, and will submit a pull request probably tomorrow.

> 
> >
> >> ---
> >>  monitor.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/monitor.c b/monitor.c
> >> index ce42466..480f583 100644
> >> --- a/monitor.c
> >> +++ b/monitor.c
> >> @@ -2570,11 +2570,11 @@ FdsetInfoList *qmp_query_fdsets(Error **errp)
> >>
> >>  int monitor_fdset_get_fd(int64_t fdset_id, int flags)
> >>  {
> >> +#ifndef _WIN32
> >>      MonFdset *mon_fdset;
> >>      MonFdsetFd *mon_fdset_fd;
> >>      int mon_fd_flags;
> >>
> >> -#ifndef _WIN32
> >>      QLIST_FOREACH(mon_fdset, &mon_fdsets, next) {
> >>          if (mon_fdset->id != fdset_id) {
> >>              continue;
> >
>