From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Wg3-0007k4-1j for qemu-devel@nongnu.org; Mon, 20 Aug 2012 14:26:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Wg1-0004XH-TA for qemu-devel@nongnu.org; Mon, 20 Aug 2012 14:26:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Wg1-0004XC-L3 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 14:26:13 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7KIQD8E019053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Aug 2012 14:26:13 -0400 Date: Mon, 20 Aug 2012 19:26:09 +0100 From: "Daniel P. Berrange" Message-ID: <20120820182609.GC4801@redhat.com> References: <1345471343-21497-1-git-send-email-berrange@redhat.com> <20120820152235.1aed6840@doriath.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20120820152235.1aed6840@doriath.home> Subject: Re: [Qemu-devel] [PATCH] Add a '-r' option to qmp-shell to print out raw JSON replies Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On Mon, Aug 20, 2012 at 03:22:35PM -0300, Luiz Capitulino wrote: > On Mon, 20 Aug 2012 15:02:23 +0100 > "Daniel P. Berrange" wrote: > > > From: "Daniel P. Berrange" > > > > By default, the JSON reply is parsed and the corresponding python > > object printed on the console. When developing JSON client apps > > for QEMU though, it is handy to see the raw JSON document instead. > > Add a '-r' option that will cause the raw JSON to be printed, > > instead of the parsed object. eg > > Looks good, but depends on the previous patch (which is being discussed). > > Btw, I wonder if we should make this the default, or add -v (instead of > -r) which would allow for extra verbosity by printing both: the reply > as read by qmp-shell and the parsed. I dunno, I feel the current default is reasonable and printing both would be a bit too verbose for commands with larger output. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|