From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T3Y8b-0008Hg-DT
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 15:59:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T3Y8Z-0001wC-O8
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 15:59:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T3Y8Z-0001vw-GE
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 15:59:47 -0400
Date: Mon, 20 Aug 2012 21:59:28 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20120820215928.4f430207@thinkpad.mammed.net>
In-Reply-To: <20120820122210.572a79b5@doriath.home>
References: <1345419579-25499-1-git-send-email-imammedo@redhat.com>
	<1345419579-25499-4-git-send-email-imammedo@redhat.com>
	<20120820122210.572a79b5@doriath.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to
 include qemu-common.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com, avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com, sw@weilnetz.de, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de

On Mon, 20 Aug 2012 12:22:10 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Mon, 20 Aug 2012 01:39:37 +0200
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > needed to prevent build breakage when CPU becomes a child of DeviceState
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  scripts/qapi-types.py |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
> > index cf601ae..f34addb 100644
> > --- a/scripts/qapi-types.py
> > +++ b/scripts/qapi-types.py
> > @@ -263,7 +263,7 @@ fdecl.write(mcgen('''
> >  #ifndef %(guard)s
> >  #define %(guard)s
> >  
> > -#include "qemu-common.h"
> > +#include <stdbool.h>
> 
> Please, also include <stdint.h>, as int64_t is used in qapi-types.h.
> 
> The build doesn't break probably because files including qapi-types.h are
> including <stdint.h> first.
Thanks for suggestion. I'll fix it for next respin.

> 
> >  
> >  ''',
> >                    guard=guardname(h_file)))
> 


-- 
Regards,
  Igor