Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h

[Igor Mammedov <imammedo@redhat.com>]

On Mon, 20 Aug 2012 12:28:05 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Mon, 20 Aug 2012 01:39:38 +0200
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  error.h |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/error.h b/error.h
> > index 96fc203..643a372 100644
> > --- a/error.h
> > +++ b/error.h
> > @@ -14,7 +14,6 @@
> >  
> >  #include "compiler.h"
> >  #include "qapi-types.h"
> > -#include <stdbool.h>
> 
> Hmm, not good. qapi-types.h includes <stdbool.h> for internal matters, files
> including qapi-types.h shouldn't rely on this (as they can break if qapi-types.h
> is changed not to include <stdbool.h>).
> 
> You can keep this code as it is.

Agreed, I'll drop this patch.
> 
> >  
> >  /**
> >   * A class representing internal errors within QEMU.  An error has a ErrorClass
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel


-- 
Regards,
  Igor