From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Y9x-0000wC-Uy for qemu-devel@nongnu.org; Mon, 20 Aug 2012 16:01:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Y9u-0002mb-V5 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 16:01:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Y9u-0002mV-MN for qemu-devel@nongnu.org; Mon, 20 Aug 2012 16:01:10 -0400 Date: Mon, 20 Aug 2012 22:00:54 +0200 From: Igor Mammedov Message-ID: <20120820220054.38e5aac0@thinkpad.mammed.net> In-Reply-To: <20120820122805.0cc63a8c@doriath.home> References: <1345419579-25499-1-git-send-email-imammedo@redhat.com> <1345419579-25499-5-git-send-email-imammedo@redhat.com> <20120820122805.0cc63a8c@doriath.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com, avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com, sw@weilnetz.de, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Mon, 20 Aug 2012 12:28:05 -0300 Luiz Capitulino wrote: > On Mon, 20 Aug 2012 01:39:38 +0200 > Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > --- > > error.h | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/error.h b/error.h > > index 96fc203..643a372 100644 > > --- a/error.h > > +++ b/error.h > > @@ -14,7 +14,6 @@ > > > > #include "compiler.h" > > #include "qapi-types.h" > > -#include > > Hmm, not good. qapi-types.h includes for internal matters, files > including qapi-types.h shouldn't rely on this (as they can break if qapi-types.h > is changed not to include ). > > You can keep this code as it is. Agreed, I'll drop this patch. > > > > > /** > > * A class representing internal errors within QEMU. An error has a ErrorClass > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel -- Regards, Igor