From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1T3lNR-0008RR-EA
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:08:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1T3lNM-0005T3-4r
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:08:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34306)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1T3lNL-0005Sx-SD
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:07:56 -0400
Date: Tue, 21 Aug 2012 11:07:50 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20120821100750.GG7982@redhat.com>
References: <1345473098-26299-1-git-send-email-berrange@redhat.com>
	<20120820160239.72e68fdf@doriath.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20120820160239.72e68fdf@doriath.home>
Subject: Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return
 target arch/bit size
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Mon, Aug 20, 2012 at 04:02:39PM -0300, Luiz Capitulino wrote:
> On Mon, 20 Aug 2012 15:31:38 +0100
> "Daniel P. Berrange" <berrange@redhat.com> wrote:
> 
> > From: "Daniel P. Berrange" <berrange@redhat.com>
> > 
> > Add a 'query-target' QAPI command to allow management applications
> > to determine what target architecture a QEMU binary is emulating
> > without having to parse the binary name or -help output
> > 
> >   $ qmp-shell -p /tmp/qemu
> >   (QEMU) query-target
> >   {   u'return': {   u'arch': u'x86_64', u'bits': 64}}
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > ---
> >  arch_init.c      | 11 +++++++++++
> >  qapi-schema.json | 25 +++++++++++++++++++++++++
> >  qmp-commands.hx  |  5 +++++
> >  3 files changed, 41 insertions(+)
> > 
> > diff --git a/arch_init.c b/arch_init.c
> > index 9b46bfc..095672d 100644
> > --- a/arch_init.c
> > +++ b/arch_init.c
> > @@ -1080,3 +1080,14 @@ int xen_available(void)
> >      return 0;
> >  #endif
> >  }
> > +
> > +
> > +TargetInfo *qmp_query_target(Error **errp)
> > +{
> > +    TargetInfo *info = g_malloc0(sizeof(*info));
> > +
> > +    info->arch = g_strdup(TARGET_ARCH);
> > +    info->bits = TARGET_PHYS_ADDR_BITS;
> > +
> > +    return info;
> > +}
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 3d2b2d1..f0e3fe0 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -2454,3 +2454,28 @@
> >  #
> >  ##
> >  { 'command': 'query-fdsets', 'returns': ['FdsetInfo'] }
> > +
> > +##
> > +# @TargetInfo:
> > +#
> > +# Information describing the QEMU target.
> > +#
> > +# @arch: the name of the target architecture (eg "x86_64", "i686", etc)
> 
> Should be an enum, otherwise looks good.

Really ? It feels a little bit odd to make this an enum IMHO.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|