From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3pKs-0006HO-B2 for qemu-devel@nongnu.org; Tue, 21 Aug 2012 10:21:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3pKn-0002IP-Bn for qemu-devel@nongnu.org; Tue, 21 Aug 2012 10:21:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3pKn-0002IL-3e for qemu-devel@nongnu.org; Tue, 21 Aug 2012 10:21:33 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7LELVhW013467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Aug 2012 10:21:32 -0400 Date: Tue, 21 Aug 2012 11:10:33 -0300 From: Luiz Capitulino Message-ID: <20120821111033.2fa8f999@doriath.home> In-Reply-To: <1345539119-26196-5-git-send-email-yhalperi@redhat.com> References: <1345539119-26196-1-git-send-email-yhalperi@redhat.com> <1345539119-26196-5-git-send-email-yhalperi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/5] spice: add 'migrated' flag to spice info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin Cc: mprivozn@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Tue, 21 Aug 2012 11:51:58 +0300 Yonit Halperin wrote: > The flag is 'true' when spice migration has completed on the src side. > It is needed for a case where libvirt dies before migration completes > and it misses the event QEVENT_SPICE_MIGRATE_COMPLETED. > When libvirt is restored and queries the migration status, it also needs > to query spice and check if its migration has completed. > > Signed-off-by: Yonit Halperin Acked-by: Luiz Capitulino > --- > hmp.c | 2 ++ > qapi-schema.json | 5 ++++- > ui/spice-core.c | 4 ++++ > 3 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/hmp.c b/hmp.c > index a9d5675..62f4dee 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -413,6 +413,8 @@ void hmp_info_spice(Monitor *mon) > monitor_printf(mon, " address: %s:%" PRId64 " [tls]\n", > info->host, info->tls_port); > } > + monitor_printf(mon, " migrated: %s\n", > + info->migrated ? "true" : "false"); > monitor_printf(mon, " auth: %s\n", info->auth); > monitor_printf(mon, " compiled: %s\n", info->compiled_version); > monitor_printf(mon, " mouse-mode: %s\n", > diff --git a/qapi-schema.json b/qapi-schema.json > index 3d2b2d1..bf3f924 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -808,6 +808,9 @@ > # > # @enabled: true if the SPICE server is enabled, false otherwise > # > +# @migrated: true if the last guest migration completed and spice > +# migration had completed as well. false otherwise. > +# > # @host: #optional The hostname the SPICE server is bound to. This depends on > # the name resolution on the host and may be an IP address. > # > @@ -833,7 +836,7 @@ > # Since: 0.14.0 > ## > { 'type': 'SpiceInfo', > - 'data': {'enabled': 'bool', '*host': 'str', '*port': 'int', > + 'data': {'enabled': 'bool', 'migrated': 'bool', '*host': 'str', '*port': 'int', > '*tls-port': 'int', '*auth': 'str', '*compiled-version': 'str', > 'mouse-mode': 'SpiceQueryMouseMode', '*channels': ['SpiceChannel']} } > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index 73f8a95..5d82c8d 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -46,6 +46,7 @@ static Notifier migration_state; > static const char *auth = "spice"; > static char *auth_passwd; > static time_t auth_expires = TIME_MAX; > +static int spice_migration_completed; > int using_spice = 0; > > static QemuThread me; > @@ -310,6 +311,7 @@ static void migrate_connect_complete_cb(SpiceMigrateInstance *sin) > static void migrate_end_complete_cb(SpiceMigrateInstance *sin) > { > monitor_protocol_event(QEVENT_SPICE_MIGRATE_COMPLETED, NULL); > + spice_migration_completed = true; > } > #endif > > @@ -442,6 +444,7 @@ SpiceInfo *qmp_query_spice(Error **errp) > } > > info->enabled = true; > + info->migrated = spice_migration_completed; > > addr = qemu_opt_get(opts, "addr"); > port = qemu_opt_get_number(opts, "port", 0); > @@ -495,6 +498,7 @@ static void migration_state_notifier(Notifier *notifier, void *data) > #ifndef SPICE_INTERFACE_MIGRATION > spice_server_migrate_switch(spice_server); > monitor_protocol_event(QEVENT_SPICE_MIGRATE_COMPLETED, NULL); > + spice_migration_completed = true; > #else > spice_server_migrate_end(spice_server, true); > } else if (migration_has_failed(s)) {