From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T3pek-0002Rc-7h
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 10:42:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T3peg-00007q-5y
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 10:42:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T3pef-00007X-Tw
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 10:42:06 -0400
Date: Tue, 21 Aug 2012 11:42:48 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120821114248.1f3f4cc7@doriath.home>
In-Reply-To: <502F927A.8060709@redhat.com>
References: <1345288635-1369-1-git-send-email-quintela@redhat.com>
	<1345288635-1369-4-git-send-email-quintela@redhat.com>
	<502F927A.8060709@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move
 total_time from ram stats to migration info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On Sat, 18 Aug 2012 07:02:50 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 08/18/2012 05:17 AM, Juan Quintela wrote:
> > Signed-off-by: Juan Quintela <quintela@redhat.com>
> > ---
> >  hmp.c            |  4 ++--
> >  migration.c      |  6 +++---
> >  qapi-schema.json | 14 +++++++-------
> >  qmp-commands.hx  |  6 +++---
> >  4 files changed, 15 insertions(+), 15 deletions(-)
> > 
> 
> > +++ b/qapi-schema.json
> > @@ -290,10 +290,6 @@
> >  #
> >  # @total: total amount of bytes involved in the migration process
> >  #
> > -# @total-time: total amount of ms since migration started.  If
> > -#        migration has ended, it returns the total migration
> > -#        time. (since 1.2)
> > -#
> >  # @duplicate: number of duplicate pages (since 1.2)
> >  #
> >  # @normal : number of normal pages (since 1.2)
> > @@ -304,8 +300,7 @@
> >  ##
> >  { 'type': 'MigrationStats',
> >    'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
> > -           'total-time': 'int', 'duplicate': 'int', 'normal': 'int',
> > -           'normal-bytes': 'int' } }
> > +           'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' } }
> > 
> >  ##
> >  # @XBZRLECacheStats
> > @@ -350,12 +345,17 @@
> >  #                migration statistics, only returned if XBZRLE feature is on and
> >  #                status is 'active' or 'completed' (since 1.2)
> >  #
> > +# @total-time: total amount of milliseconds since migration started.
> > +#        If migration has ended, it returns the total migration
> > +#        time. (since 1.2)

Field is optional, needs to be marked as such and the has_total_time field
should be set appropriately.

> > +#
> >  # Since: 0.14.0
> >  ##
> >  { 'type': 'MigrationInfo',
> >    'data': {'*status': 'str', '*ram': 'MigrationStats',
> >             '*disk': 'MigrationStats',
> > -           '*xbzrle-cache': 'XBZRLECacheStats'} }
> > +           '*xbzrle-cache': 'XBZRLECacheStats',
> > +           'total-time': 'int'} }
> 
> Anthony - are you planning on taking this series for 1.2?  If we don't
> get this patch in on time, then taking this for 1.3 would result in
> changing released QMP interface (right now, there has been no release
> with the field in the wrong type).

I can cherry-pick this into the qmp branch.

Juan, I can also fix myself the problem I pointed out above if that
works for you.