From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru,
qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com,
kraxel@redhat.com, xen-devel@lists.xensource.com,
i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com,
avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com,
stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com,
sw@weilnetz.de, imammedo@redhat.com, rth@twiddle.net,
kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com,
pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC 3/8] qapi-types.h doesn't really need to include qemu-common.h
Date: Tue, 21 Aug 2012 15:21:48 -0300 [thread overview]
Message-ID: <20120821152148.3bcff810@doriath.home> (raw)
In-Reply-To: <1345563782-11224-4-git-send-email-ehabkost@redhat.com>
On Tue, 21 Aug 2012 12:42:57 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> From: Igor Mammedov <imammedo@redhat.com>
>
> needed to prevent build breakage when CPU becomes a child of DeviceState
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> scripts/qapi-types.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
> index cf601ae..f34addb 100644
> --- a/scripts/qapi-types.py
> +++ b/scripts/qapi-types.py
> @@ -263,7 +263,7 @@ fdecl.write(mcgen('''
> #ifndef %(guard)s
> #define %(guard)s
>
> -#include "qemu-common.h"
> +#include <stdbool.h>
Case you didn't notice my last review: we should also include <stdint.h> here.
>
> ''',
> guard=guardname(h_file)))
next prev parent reply other threads:[~2012-08-21 18:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 15:42 [Qemu-devel] [RFC 0/8] include qdev core in *-user, make CPU child of DeviceState Eduardo Habkost
2012-08-21 15:42 ` [Qemu-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h Eduardo Habkost
2012-08-21 16:10 ` Peter Maydell
2012-08-27 14:28 ` Igor Mammedov
2012-08-29 15:36 ` [Qemu-devel] [Xen-devel] " Igor Mammedov
2012-08-29 15:38 ` Peter Maydell
2012-08-21 15:42 ` [Qemu-devel] [RFC 2/8] qdev: split up header so it can be used in cpu.h Eduardo Habkost
2012-08-21 15:42 ` [Qemu-devel] [RFC 3/8] qapi-types.h doesn't really need to include qemu-common.h Eduardo Habkost
2012-08-21 18:21 ` Luiz Capitulino [this message]
2012-08-21 15:42 ` [Qemu-devel] [RFC 4/8] cleanup error.h, included qapi-types.h aready has stdbool.h Eduardo Habkost
2012-08-21 16:45 ` Peter Maydell
2012-08-21 16:53 ` Eduardo Habkost
2012-08-21 15:42 ` [Qemu-devel] [RFC 5/8] split qdev into a core and code used only by qemu-system-* Eduardo Habkost
2012-08-21 18:44 ` Blue Swirl
2012-08-21 15:43 ` [Qemu-devel] [RFC 6/8] qdev: use full qdev.h include path on qdev*.c Eduardo Habkost
2012-08-21 16:29 ` Peter Maydell
2012-08-21 18:25 ` Eduardo Habkost
2012-08-21 15:43 ` [Qemu-devel] [RFC 7/8] include core qdev code into *-user, too Eduardo Habkost
2012-08-21 16:59 ` Peter Maydell
2012-08-21 18:55 ` Eduardo Habkost
2012-08-21 15:43 ` [Qemu-devel] [RFC 8/8] make CPU a child of DeviceState Eduardo Habkost
2012-08-22 9:05 ` [Qemu-devel] [RFC 0/8] include qdev core in *-user, make CPU " Avi Kivity
2012-08-22 13:08 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821152148.3bcff810@doriath.home \
--to=lcapitulino@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=i.mitsyanko@samsung.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@linux.vnet.ibm.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).