From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"patches@linaro.org" <patches@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()
Date: Thu, 23 Aug 2012 06:13:29 -0300 [thread overview]
Message-ID: <20120823091329.GA32710@amt.cnet> (raw)
In-Reply-To: <503362A7.4010106@siemens.com>
On Tue, Aug 21, 2012 at 12:27:51PM +0200, Jan Kiszka wrote:
> On 2012-08-21 10:25, Peter Maydell wrote:
> > On 21 August 2012 09:19, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >> On 2012-08-15 13:08, Peter Maydell wrote:
> >>> Move the init of the irqchip_inject_ioctl field of KVMState out of
> >>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq()
> >>> can be used even when no irqchip is created (for architectures
> >>> that support async interrupt notification even without an in
> >>> kernel irqchip).
> >
> >> As it's not yet merged, some late comment: irqchip_inject_ioctl should
> >> be renamed as well. irq_inject_ioctl?
> >
> > If we're changing it anyway, IIRC Avi didn't like the term "inject"
> > here?
>
> Then irq_set_ioctl.
>
> Jan
It is merged, please send a follow patch.
next prev parent reply other threads:[~2012-08-23 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 11:08 [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Peter Maydell
2012-08-15 18:34 ` Marcelo Tosatti
2012-08-21 8:19 ` Jan Kiszka
2012-08-21 8:25 ` Peter Maydell
2012-08-21 10:27 ` Jan Kiszka
2012-08-23 9:13 ` Marcelo Tosatti [this message]
2012-08-23 14:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120823091329.GA32710@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).