From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T4uEc-0007Xz-4h
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 09:47:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T4uEa-0005Kt-Pb
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 09:47:37 -0400
Date: Fri, 24 Aug 2012 10:48:13 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120824104813.4345db29@doriath.home>
In-Reply-To: <1345784583-25640-1-git-send-email-sw@weilnetz.de>
References: <1345784583-25640-1-git-send-email-sw@weilnetz.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for 1.2] qemu-ga: Fix null pointer passed
 to unlink in failure branch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Fri, 24 Aug 2012 07:03:03 +0200
Stefan Weil <sw@weilnetz.de> wrote:

> Clang reports this warning:
> 
> Null pointer passed as an argument to a 'nonnull' parameter
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

> ---
>  qemu-ga.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-ga.c b/qemu-ga.c
> index 26671fe..7623079 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -438,7 +438,9 @@ static void become_daemon(const char *pidfile)
>      return;
>  
>  fail:
> -    unlink(pidfile);
> +    if (pidfile) {
> +        unlink(pidfile);
> +    }
>      g_critical("failed to daemonize");
>      exit(EXIT_FAILURE);
>  #endif