From: Stefan Hajnoczi <stefanha@gmail.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel
Date: Fri, 24 Aug 2012 12:16:37 +0100 [thread overview]
Message-ID: <20120824111637.GH10867@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <Pine.GSO.4.64.1208221718470.28960@mono>
On Wed, Aug 22, 2012 at 05:19:42PM +0200, BALATON Zoltan wrote:
> Division with round up is the correct way to compute this even if the
> only case where division with round down gives incorrect result is
> probably 15 bpp. This case was explicitely patched up in one of these
> functions but was unhandled in the other. (I'm not sure about setting
> 16 bpp for the 15bpp case either but I left that there for now.)
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> console.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> v2: Use DIV_ROUND_UP and extended commit message
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2012-08-24 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 15:19 [Qemu-devel] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel BALATON Zoltan
2012-08-22 15:32 ` Jan Kiszka
2012-08-22 16:29 ` Stefan Weil
2012-08-22 16:44 ` Jan Kiszka
2012-08-22 16:56 ` Jan Kiszka
2012-08-24 11:20 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-08-24 11:21 ` Jan Kiszka
2012-08-24 11:53 ` Stefan Hajnoczi
2012-08-24 11:16 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824111637.GH10867@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).