From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1T4sZU-0000qU-R4
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 08:01:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1T4sZS-000778-Qx
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 08:01:04 -0400
Received: from speedy.comstyle.com ([206.51.28.2]:47543 helo=mail.comstyle.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1T4sZS-00076H-Nc
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 08:01:02 -0400
Date: Fri, 24 Aug 2012 08:00:54 -0400
From: Brad Smith <brad@comstyle.com>
Message-ID: <20120824120053.GQ29273@rox.home.comstyle.com>
References: <20120824094738.GH29273@rox.home.comstyle.com>
	<CAFEAcA_6C3eQEUy1q8eNxTUdbGcH=8ida56Ded9rP_h8yrimWQ@mail.gmail.com>
	<50376BEF.5060206@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50376BEF.5060206@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On Fri, Aug 24, 2012 at 01:56:31PM +0200, Paolo Bonzini wrote:
> Il 24/08/2012 11:55, Peter Maydell ha scritto:
> >> > OpenBSD's uname works as expected with the -s flag so remove the special
> >> > handling when determining the target OS. Use arch -s to retrieve the
> >> > hardware architecture as uname -m will return the meta architecture
> >> > instead of the hardware architecture (.e.g. macppc vs powerpc).
> > I'm afraid I think this patch is moving in the wrong direction.
> > Wherever possible we should be using compiler checks like check_define,
> > not looking at the output of 'uname' and the like. The former will
> > work when cross compiling, and the latter will give the wrong answers.
> > In some places we have that kind of 'look at uname/etc' check but
> > we should be trying to reduce and eliminate it where possible.
> 
> Right, we should support GNU triplets and a --host argument, and replace
> uname checks with pattern matching on the triplet.

That still requires a means of generating that triplet in the first place.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.