From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4z13-0000ki-Q2 for qemu-devel@nongnu.org; Fri, 24 Aug 2012 14:53:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4z0x-0004b6-UM for qemu-devel@nongnu.org; Fri, 24 Aug 2012 14:53:57 -0400 Received: from hall.aurel32.net ([88.191.126.93]:58670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4z0x-0004az-OV for qemu-devel@nongnu.org; Fri, 24 Aug 2012 14:53:51 -0400 Date: Fri, 24 Aug 2012 20:53:48 +0200 From: Aurelien Jarno Message-ID: <20120824185348.GH1687@hall.aurel32.net> References: <20120824150557.GG1687@hall.aurel32.net> <5037A33D.3070907@suse.de> <20120824180557.GJ3553@ohm.aurel32.net> <5037CB54.9030800@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5037CB54.9030800@suse.de> Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-15?Q?F=E4rber?= Cc: Blue Swirl , Peter Maydell , qemu-devel , Alexander Graf On Fri, Aug 24, 2012 at 08:43:32PM +0200, Andreas Färber wrote: > Am 24.08.2012 20:05, schrieb Aurelien Jarno: > > On Fri, Aug 24, 2012 at 05:52:29PM +0200, Andreas Färber wrote: > >> Not opposed to changing the argument order, but given that we're inches > >> away from v1.2 (in Hard Freeze), it might be better to first get AREG0 > >> as first argument working for your favorite hosts as a bugfix and then > >> do any larger optimization for v1.3. > > > > It's what I tried to do first, but I don't think it is realistic to use > > such a code for v1.2, it is complex to support all cases, and thus > > likely full of bugs. Maybe we should simply disable ARM and MIPS support > > for this release. > > Depends on what you mean with "disable"? Adding an #error would hurt our > arm build just like earlier the ppc build, and I would hope from my last > testing that the problems would only affect the AREG0 targets, > especially not ARM on ARM (or MIPS on MIPS). > I mean basically not building qemu-system-{alpha,i386,x86_64,or32,sparc, sparc64,xtensa,ppc,ppc64} on arm and mips hosts. > Aborting at runtime, only when really unsupported, would seem better. What's the point of providing non working binaries, beside getting bug reports? > > I had taken a look at tcg/arm/ shortly after having fixed ppc (seeing > that there was a similar TODO or FIXME) but got distracted by other > projects. And your remarks wrt stack sound a bit frightening now. ;) > @Peter, have you looked into tcg/arm/ AREG0 support? > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net