From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Frl-0008NO-0y for qemu-devel@nongnu.org; Sat, 25 Aug 2012 08:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T5Frj-0004P1-J1 for qemu-devel@nongnu.org; Sat, 25 Aug 2012 08:53:28 -0400 Received: from hall.aurel32.net ([88.191.126.93]:57831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Frj-0004OY-Cf for qemu-devel@nongnu.org; Sat, 25 Aug 2012 08:53:27 -0400 Date: Sat, 25 Aug 2012 14:53:23 +0200 From: Aurelien Jarno Message-ID: <20120825125323.GA17750@hall.aurel32.net> References: <20120824150557.GG1687@hall.aurel32.net> <5037A33D.3070907@suse.de> <20120824180557.GJ3553@ohm.aurel32.net> <5037CB54.9030800@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , Alexander Graf , Andreas =?iso-8859-15?Q?F=E4rber?= , qemu-devel On Sat, Aug 25, 2012 at 12:01:26AM +0100, Peter Maydell wrote: > On 24 August 2012 19:43, Andreas Färber wrote: > > Depends on what you mean with "disable"? Adding an #error would hurt our > > arm build just like earlier the ppc build, and I would hope from my last > > testing that the problems would only affect the AREG0 targets, > > especially not ARM on ARM (or MIPS on MIPS). > > > > Aborting at runtime, only when really unsupported, would seem better. > > > > I had taken a look at tcg/arm/ shortly after having fixed ppc (seeing > > that there was a similar TODO or FIXME) but got distracted by other > > projects. And your remarks wrt stack sound a bit frightening now. ;) > > @Peter, have you looked into tcg/arm/ AREG0 support? > > Not yet. Why did we commit something that broke half our TCG > targets and why don't we just back it out for 1.2 ? > I haven't tried, but for what I can see in the commit log, it was already broken in 1.1. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net