* [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands
@ 2012-08-27 8:53 Richard Sandiford
2012-08-27 9:07 ` Stefan Hajnoczi
2012-08-27 10:20 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Richard Sandiford @ 2012-08-27 8:53 UTC (permalink / raw)
To: qemu-devel
The FS input to CVT.PS.S is the high half and FT is the low half.
tcg_gen_concat_i32_i64 takes the low half first, so the operands
were in the wrong order.
Signed-off-by: Richard Sandiford <rdsandiford@googlemail.com>
---
target-mips/translate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index 06f0ac6..defc021 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -6907,7 +6907,7 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
gen_load_fpr32(fp32_0, fs);
gen_load_fpr32(fp32_1, ft);
- tcg_gen_concat_i32_i64(fp64, fp32_0, fp32_1);
+ tcg_gen_concat_i32_i64(fp64, fp32_1, fp32_0);
tcg_temp_free_i32(fp32_1);
tcg_temp_free_i32(fp32_0);
gen_store_fpr64(ctx, fp64, fd);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands
2012-08-27 8:53 [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands Richard Sandiford
@ 2012-08-27 9:07 ` Stefan Hajnoczi
2012-08-27 10:20 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-08-27 9:07 UTC (permalink / raw)
To: qemu-devel, rdsandiford, Aurelien Jarno
On Mon, Aug 27, 2012 at 9:53 AM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> The FS input to CVT.PS.S is the high half and FT is the low half.
> tcg_gen_concat_i32_i64 takes the low half first, so the operands
> were in the wrong order.
>
> Signed-off-by: Richard Sandiford <rdsandiford@googlemail.com>
> ---
> target-mips/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 06f0ac6..defc021 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -6907,7 +6907,7 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
>
> gen_load_fpr32(fp32_0, fs);
> gen_load_fpr32(fp32_1, ft);
> - tcg_gen_concat_i32_i64(fp64, fp32_0, fp32_1);
> + tcg_gen_concat_i32_i64(fp64, fp32_1, fp32_0);
> tcg_temp_free_i32(fp32_1);
> tcg_temp_free_i32(fp32_0);
> gen_store_fpr64(ctx, fp64, fd);
> --
> 1.7.7.6
CCing Aurelian for MIPS. You can look at ./MAINTAINERS to see who
should be CCed.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands
2012-08-27 8:53 [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands Richard Sandiford
2012-08-27 9:07 ` Stefan Hajnoczi
@ 2012-08-27 10:20 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2012-08-27 10:20 UTC (permalink / raw)
To: qemu-devel, rdsandiford
On Mon, Aug 27, 2012 at 09:53:29AM +0100, Richard Sandiford wrote:
> The FS input to CVT.PS.S is the high half and FT is the low half.
> tcg_gen_concat_i32_i64 takes the low half first, so the operands
> were in the wrong order.
>
> Signed-off-by: Richard Sandiford <rdsandiford@googlemail.com>
> ---
> target-mips/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 06f0ac6..defc021 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -6907,7 +6907,7 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
>
> gen_load_fpr32(fp32_0, fs);
> gen_load_fpr32(fp32_1, ft);
> - tcg_gen_concat_i32_i64(fp64, fp32_0, fp32_1);
> + tcg_gen_concat_i32_i64(fp64, fp32_1, fp32_0);
> tcg_temp_free_i32(fp32_1);
> tcg_temp_free_i32(fp32_0);
> gen_store_fpr64(ctx, fp64, fd);
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-27 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-27 8:53 [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands Richard Sandiford
2012-08-27 9:07 ` Stefan Hajnoczi
2012-08-27 10:20 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).