From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T60fu-0001Ko-Kn for qemu-devel@nongnu.org; Mon, 27 Aug 2012 10:52:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T60fo-00028w-0P for qemu-devel@nongnu.org; Mon, 27 Aug 2012 10:52:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T60fn-00028Y-N8 for qemu-devel@nongnu.org; Mon, 27 Aug 2012 10:52:15 -0400 Date: Mon, 27 Aug 2012 17:53:22 +0300 From: "Michael S. Tsirkin" Message-ID: <20120827145322.GC779@redhat.com> References: <6dcaad57552e08e4ec799d814cdcbd1c38c7f37b.1346069810.git.mst@redhat.com> <503B6CB9.6000407@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <503B6CB9.6000407@siemens.com> Subject: Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Peter Maydell , kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, avi@redhat.com, Anthony Liguori On Mon, Aug 27, 2012 at 02:48:57PM +0200, Jan Kiszka wrote: > On 2012-08-27 14:42, Peter Maydell wrote: > > On 27 August 2012 13:20, Michael S. Tsirkin wrote: > >> Update linux-headers to version present in Linux 3.6-rc3. > >> Header asm-x96_64/kvm_para.h update is needed for the new PV EOI > >> feature. > >> > >> Signed-off-by: Michael S. Tsirkin > >> --- > >> linux-headers/asm-s390/kvm.h | 2 +- > >> linux-headers/asm-s390/kvm_para.h | 2 +- > >> linux-headers/asm-x86/kvm.h | 1 + > >> linux-headers/asm-x86/kvm_para.h | 7 +++++++ > >> linux-headers/linux/kvm.h | 3 +++ > >> 5 files changed, 13 insertions(+), 2 deletions(-) > > > > The latest version of update-linux-headers.sh should have caused > > this update to include asm-generic/kvm_para.h, I think. Did the > > script not pull that header in, or were you maybe using an old > > version of the script or forgot to git add the new file? > > To be fair, that is hard to guess. We should add some magic to the > update script to detect new files and maybe suggest them for addition. > > Jan But why did you add a header to qemu without adding it to git? That's a cleaner solution and needs no magic scripting. > -- > Siemens AG, Corporate Technology, CT RTC ITP SDP-DE > Corporate Competence Center Embedded Linux