From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T64rm-0001l9-A2
	for qemu-devel@nongnu.org; Mon, 27 Aug 2012 15:20:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T64ri-0005oH-4N
	for qemu-devel@nongnu.org; Mon, 27 Aug 2012 15:20:54 -0400
Received: from paradis.irqsave.net ([109.190.18.76]:54464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T64rh-0005o3-OK
	for qemu-devel@nongnu.org; Mon, 27 Aug 2012 15:20:50 -0400
Date: Mon, 27 Aug 2012 21:20:42 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20120827192042.GB4498@irqsave.net>
References: <1346052629-15686-1-git-send-email-benoit@irqsave.net>
	<1346052629-15686-4-git-send-email-benoit@irqsave.net>
	<503BB586.5000503@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <503BB586.5000503@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC V5 03/11] quorum: Add quorum_open() and
 quorum_close().
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@gmail.com>, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com

Le Monday 27 Aug 2012 =E0 11:59:34 (-0600), Eric Blake a =E9crit :
> On 08/27/2012 01:30 AM, Beno=EEt Canet wrote:
> > Valid quorum resources look like
> > quorum:threshold/total:path/to/image_1, ... ,path/to/image_total
> >=20
> > ',' is used as a separator to allow to use networked path
>=20
> Isn't this a step backwards?  After all, on the command line, we would
> have something like:
>=20
> -drive file=3Dquorum:...,readonly=3Don
>=20
> but if the 'quorum:...' portion contains commas, then the qemu option
> parsing requires you to write those commas as doubled.  Which means to
> escape those commas for _both_ quorum: processing _and_ qemu command
> line parsing, I'd have to write:
>=20
> -drive "file=3Dquorum:2/2:path/to/image\\,,1,,path/to/image\\\\2,readon=
ly=3Don"
>=20
> to use the two files:
> path/to/image,1
> path/to/image\2
>=20
> with appropriate shell, qemu, and quorum escaping.  Using : rather than
> , as the separator between quorum: elements was a bit simpler, since I
> don't have to type double commas for every single comma to be taken by
> the quorum parsing, escaped or not.
>=20
> > '\' is the escaping character for filename containing ','
> > '\' escape itself
>=20
> s/escape/escapes/
>=20
> >=20
> > On the command line for quorum files "img,test.raw", "img2.raw"
> > and "img3.raw" invocation look like:
> >=20
> > -drive file=3Dquorum:2/3:img\\,,test.raw,,img2.raw,,img3.raw
> > (note the double ,, and \\)
>=20
> Yes, that's what I'm worried about.

I was following an idea of Blue Swirl.

You will have to use \\ on the command line.
':' can be used instead of ',' but it won't work
with networked urls.

>=20
> --=20
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20