From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6Obn-0006Ke-8D for qemu-devel@nongnu.org; Tue, 28 Aug 2012 12:25:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6Obl-0006X9-SN for qemu-devel@nongnu.org; Tue, 28 Aug 2012 12:25:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6Obl-0006Wi-LS for qemu-devel@nongnu.org; Tue, 28 Aug 2012 12:25:41 -0400 Date: Tue, 28 Aug 2012 13:23:18 -0300 From: Marcelo Tosatti Message-ID: <20120828162317.GA30308@amt.cnet> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: gleb@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, Jan Kiszka , avi@redhat.com, Anthony Liguori On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > In preparation to adding PV EOI migration for 1.2, > trivially refactor some some compat code > to make it easier to add version specific > cpuid tweaks. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pc_piix.c | 44 ++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 36 insertions(+), 8 deletions(-) Why can't you clear the cpuid bit in kvm paravirt leaf at hw/pc_piix.c, leaving compat code isolated there?