From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56794)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1T6Pgg-0002hA-DH
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:34:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1T6Pgc-0002dX-AN
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:34:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61891)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1T6Pgc-0002cW-0h
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:34:46 -0400
Date: Tue, 28 Aug 2012 20:35:59 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120828173558.GG3661@redhat.com>
References: <20120828160116.GA3047@redhat.com>
	<CAAu8pHv9B-4V=FAud4RW7qvJZOpZ2p8Kbd4u_Wcq-AVDVx+Rwg@mail.gmail.com>
	<20120828172146.GB3661@redhat.com>
	<CAFEAcA-nPJ-YvJ=Ezr1VrMmB8pxgi0EeJ5YmmE6s+D1SoDNQSA@mail.gmail.com>
	<alpine.LNX.2.00.1208282132250.3395@linmac>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1208282132250.3395@linmac>
Subject: Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On Tue, Aug 28, 2012 at 09:33:16PM +0400, malc wrote:
> On Tue, 28 Aug 2012, Peter Maydell wrote:
> 
> > On 28 August 2012 18:21, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0.
> > > And if it does happen then you run a simple script and fix
> > > this one instance.
> > 
> > Why not just use a name that doesn't use a double underscore
> > in the first place? The C standard specifically allows single
> > underscore + lowercase to give things other than the implementation
> > part of the underscore-namespace. In this case, "_kvm_pv_eoi"
> > would be OK.
> 
> No it wouldn't, _kvm_pv_eoi is a file scope identifier, and names 
> beginning with underscore are reserved in this context.

Looks like they are and I missed that.
Maybe we should add that to HACKING.

> > 
> > >> The tiny single benefit from violating the rules would be that you
> > >> could use a few additional possible classes of prefixes, in addition
> > >> to the infinite combinations already available.
> > >
> > > Benefit would be consistency with existing QEMU code
> > > which has both _t __  and _X, and consistency
> > > within HACKING itself.
> > 
> > HACKING and CODING_STYLE contain a number of rules which
> > the existing codebase doesn't fully conform to. The idea
> > is to incrementally improve consistency and correctness.
> > 
> > -- PMM
> > 
> 
> -- 
> mailto:av1474@comtv.ru