From: "Michael S. Tsirkin" <mst@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: gleb@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com,
qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@web.de>,
avi@redhat.com, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types
Date: Tue, 28 Aug 2012 20:38:59 +0300 [thread overview]
Message-ID: <20120828173859.GA4302@redhat.com> (raw)
In-Reply-To: <CAAu8pHvdwZ=GconZZ7V3yw+5os7EHcKyMURxCxV5u_XNEtr5Jw@mail.gmail.com>
On Tue, Aug 28, 2012 at 05:28:22PM +0000, Blue Swirl wrote:
> On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote:
> >> > +static bool _kvm_pv_eoi_disabled;
> >>
> >> NACK. I find your lack of compliance disturbing.
> >
> > Compliance with what? Could you please add some
> > motivation for the NACK?
>
> You did not respect my review comments.
I merely asking for motivation for the comments.
Anyway, malc explained it to me so I got it now.
Thanks for the review will post soon.
> >
> > --
> > MST
next prev parent reply other threads:[~2012-08-28 17:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 13:21 [Qemu-devel] [PATCHv3 0/4] migrate PV EOI MSR Michael S. Tsirkin
2012-08-28 13:22 ` [Qemu-devel] [PATCHv3 1/4] linux-headers: update to 3.6-rc3 Michael S. Tsirkin
2012-08-28 13:22 ` [Qemu-devel] [PATCHv3 2/4] pc: refactor compat code Michael S. Tsirkin
2012-08-28 13:22 ` [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types Michael S. Tsirkin
2012-08-28 17:05 ` Blue Swirl
2012-08-28 17:22 ` Michael S. Tsirkin
2012-08-28 17:28 ` Blue Swirl
2012-08-28 17:38 ` Michael S. Tsirkin [this message]
2012-08-28 13:22 ` [Qemu-devel] [PATCHv3 4/4] kvm: get/set PV EOI MSR Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828173859.GA4302@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).