From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PjZ-0003s0-NL for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:37:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6PjY-00047R-I7 for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:37:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PjY-00047I-9o for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:37:48 -0400 Date: Tue, 28 Aug 2012 20:38:59 +0300 From: "Michael S. Tsirkin" Message-ID: <20120828173859.GA4302@redhat.com> References: <20120828172258.GC3661@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: gleb@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, Jan Kiszka , avi@redhat.com, Anthony Liguori On Tue, Aug 28, 2012 at 05:28:22PM +0000, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote: > >> > +static bool _kvm_pv_eoi_disabled; > >> > >> NACK. I find your lack of compliance disturbing. > > > > Compliance with what? Could you please add some > > motivation for the NACK? > > You did not respect my review comments. I merely asking for motivation for the comments. Anyway, malc explained it to me so I got it now. Thanks for the review will post soon. > > > > -- > > MST