From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6kJs-0001yN-5I for qemu-devel@nongnu.org; Wed, 29 Aug 2012 11:36:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6kJn-0005SH-O0 for qemu-devel@nongnu.org; Wed, 29 Aug 2012 11:36:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6kJn-0005Ro-Fd for qemu-devel@nongnu.org; Wed, 29 Aug 2012 11:36:35 -0400 Date: Wed, 29 Aug 2012 17:36:04 +0200 From: Igor Mammedov Message-ID: <20120829173604.77f90e52@thinkpad.mammed.net> In-Reply-To: References: <1345563782-11224-1-git-send-email-ehabkost@redhat.com> <1345563782-11224-2-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, armbru@redhat.com, avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, Eduardo Habkost , stefano.stabellini@eu.citrix.com, sw@weilnetz.de, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Tue, 21 Aug 2012 17:10:48 +0100 Peter Maydell wrote: > On 21 August 2012 16:42, Eduardo Habkost wrote: > > diff --git a/qemu-common.h b/qemu-common.h > > index e5c2bcd..6677a30 100644 > > --- a/qemu-common.h > > +++ b/qemu-common.h > > @@ -273,7 +273,6 @@ typedef struct PCIEPort PCIEPort; > > typedef struct PCIESlot PCIESlot; > > typedef struct MSIMessage MSIMessage; > > typedef struct SerialState SerialState; > > -typedef struct IRQState *qemu_irq; > > typedef struct PCMCIACardState PCMCIACardState; > > typedef struct MouseTransformInfo MouseTransformInfo; > > typedef struct uWireSlave uWireSlave; > > diff --git a/sysemu.h b/sysemu.h > > index 65552ac..f765821 100644 > > --- a/sysemu.h > > +++ b/sysemu.h > > @@ -9,6 +9,7 @@ > > #include "qapi-types.h" > > #include "notify.h" > > #include "main-loop.h" > > +#include "hw/irq.h" > > > > /* vl.c */ > > I'm not objecting to this patch if it helps us move forwards, > but adding the #include to sysemu.h is effectively just adding > the definition to another grabbag header (183 files include > sysemu.h). It would be nicer long-term to separate out the > one thing in this header that cares about qemu_irq (the extern > declaration of qemu_system_powerdown). > [I'm not really convinced that a qemu_irq is even the right > way to signal "hey the system has actually powered down now"...] Instead of global qemu_system_powerdown we could use notifiers like it's done for suspend, I'll post patches today after testing them on target-i386. BTW getting rid of qemu_system_powerdown is orthogonal to topic of this series. I hope you won't object to this patch providing there will be follow on series to deal with qemu_system_powerdown. > > -- PMM > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel -- Regards, Igor