From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6mkk-0006yS-CR for qemu-devel@nongnu.org; Wed, 29 Aug 2012 14:12:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6mkj-0002AV-FJ for qemu-devel@nongnu.org; Wed, 29 Aug 2012 14:12:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6mkj-0002AP-7F for qemu-devel@nongnu.org; Wed, 29 Aug 2012 14:12:33 -0400 Date: Wed, 29 Aug 2012 21:13:50 +0300 From: "Michael S. Tsirkin" Message-ID: <20120829181350.GF7877@redhat.com> References: <20120829164056.GA7792@redhat.com> <503E494B.8010507@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <503E494B.8010507@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.2] msix: make [un]use vectors on reset/load optional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Jan Kiszka , Anthony Liguori , Alex Williamson , qemu-devel@nongnu.org, Avi Kivity On Wed, Aug 29, 2012 at 06:54:35PM +0200, Andreas F=E4rber wrote: > $subject: "[un]used vectors"? -- could be fixed by committer. >=20 > /-F Sorry I don't unedrstand. it's not 'unused': it's use and unuse. What is wrong with the subject? > Am 29.08.2012 18:40, schrieb Michael S. Tsirkin: > > The facility to use/unuse vectors dynamically is helpful > > for virtio but little else: everyone just seems to use > > vectors in their init function. > >=20 > > Avoid clearing msix vector use info on reset and load. > > For virtio, clear it explicitly. > > This should fix regressions reported with ivshmem - though > > I didn't test this, I verified that virtio keeps > > working like it did. > >=20 > > Signed-off-by: Michael S. Tsirkin >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg