From: Stefan Hajnoczi <stefanha@gmail.com>
To: Bo Yang <boyang@suse.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100.
Date: Thu, 30 Aug 2012 08:26:04 +0100 [thread overview]
Message-ID: <20120830072604.GB6814@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <503EAA1A.2090207@suse.com>
On Thu, Aug 30, 2012 at 07:47:38AM +0800, Bo Yang wrote:
> On 08/29/2012 11:19 PM, Stefan Hajnoczi wrote:
> > On Wed, Aug 29, 2012 at 07:26:11PM +0800, Bo Yang wrote:
> >> This is reported by QA. When installing os with pxe, after the initial
> >> kernel and initrd are loaded, the procedure tries to copy files from install
> >> server to local harddisk, the network becomes stall because of running out of
> >> receive descriptor.
> >>
> >> Signed-off-by: Bo Yang <boyang@suse.com>
> >> ---
> >> hw/eepro100.c | 5 ++++-
> >> 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > Thanks, applied to the net patches tree:
> > https://github.com/stefanha/qemu/commits/net
> >
> > I have reproduced the bug and tested that your patch fixes it. Your
> > patch also has tabs instead of spaces, I fixed that up when merging.
>
> Thanks for verifying and merging the patch. Sorry for my mistake in
> coding style. I'll be careful next time. I use vim, it looks like set
> tabstop=4 is not enough to get it work as expected.
set tabstop=4 " display tabs as 4 spaces
set expandtab " use spaces instead of tabs
set shiftwidth=4 " indent by 4 spaces
next prev parent reply other threads:[~2012-08-30 8:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 11:26 [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100 Bo Yang
2012-08-29 15:19 ` Stefan Hajnoczi
2012-08-29 23:47 ` Bo Yang
2012-08-30 7:26 ` Stefan Hajnoczi [this message]
2012-08-29 19:17 ` Stefan Weil
2012-08-29 23:52 ` Bo Yang
2012-08-30 8:04 ` Stefan Hajnoczi
2012-08-30 8:38 ` Bo Yang
2012-08-30 11:42 ` Stefan Hajnoczi
2012-08-31 3:40 ` Bo Yang
2012-08-31 5:30 ` Stefan Hajnoczi
2012-09-18 15:19 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830072604.GB6814@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=boyang@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).