From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6zkB-0004Fq-HF for qemu-devel@nongnu.org; Thu, 30 Aug 2012 04:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6zk7-0006Kb-C6 for qemu-devel@nongnu.org; Thu, 30 Aug 2012 04:04:51 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:55678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6zk7-0006Jm-67 for qemu-devel@nongnu.org; Thu, 30 Aug 2012 04:04:47 -0400 Received: by wibhm2 with SMTP id hm2so5252589wib.10 for ; Thu, 30 Aug 2012 01:04:46 -0700 (PDT) Date: Thu, 30 Aug 2012 08:26:04 +0100 From: Stefan Hajnoczi Message-ID: <20120830072604.GB6814@stefanha-thinkpad.localdomain> References: <1346239571-23359-1-git-send-email-boyang@suse.com> <20120829151959.GA22246@stefanha-thinkpad.localdomain> <503EAA1A.2090207@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <503EAA1A.2090207@suse.com> Subject: Re: [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bo Yang Cc: qemu-devel@nongnu.org On Thu, Aug 30, 2012 at 07:47:38AM +0800, Bo Yang wrote: > On 08/29/2012 11:19 PM, Stefan Hajnoczi wrote: > > On Wed, Aug 29, 2012 at 07:26:11PM +0800, Bo Yang wrote: > >> This is reported by QA. When installing os with pxe, after the initial > >> kernel and initrd are loaded, the procedure tries to copy files from install > >> server to local harddisk, the network becomes stall because of running out of > >> receive descriptor. > >> > >> Signed-off-by: Bo Yang > >> --- > >> hw/eepro100.c | 5 ++++- > >> 1 files changed, 4 insertions(+), 1 deletions(-) > > > > Thanks, applied to the net patches tree: > > https://github.com/stefanha/qemu/commits/net > > > > I have reproduced the bug and tested that your patch fixes it. Your > > patch also has tabs instead of spaces, I fixed that up when merging. > > Thanks for verifying and merging the patch. Sorry for my mistake in > coding style. I'll be careful next time. I use vim, it looks like set > tabstop=4 is not enough to get it work as expected. set tabstop=4 " display tabs as 4 spaces set expandtab " use spaces instead of tabs set shiftwidth=4 " indent by 4 spaces