From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T73mn-0000Pc-Kz for qemu-devel@nongnu.org; Thu, 30 Aug 2012 08:23:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T73mh-00042l-R6 for qemu-devel@nongnu.org; Thu, 30 Aug 2012 08:23:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T73mh-00042d-Ic for qemu-devel@nongnu.org; Thu, 30 Aug 2012 08:23:43 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7UCNfsc019443 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Aug 2012 08:23:42 -0400 Date: Thu, 30 Aug 2012 09:11:43 -0300 From: Luiz Capitulino Message-ID: <20120830091143.0ceb60c4@doriath.home> In-Reply-To: <1a792397f896fe2c5106eb55e58d0e3c8a3032c3.1345016001.git.phrdina@redhat.com> References: <1a792397f896fe2c5106eb55e58d0e3c8a3032c3.1345016001.git.phrdina@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/18] qerror: introduce QERR_GENERIC_ERROR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org On Wed, 15 Aug 2012 09:41:42 +0200 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > qerror.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qerror.h b/qerror.h > index d0a76a4..7e0bae7 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -120,6 +120,9 @@ void assert_no_error(Error *err); > #define QERR_FEATURE_DISABLED \ > ERROR_CLASS_GENERIC_ERROR, "The feature '%s' is not enabled" > > +#define QERR_GENERIC_ERROR \ > + ERROR_CLASS_GENERIC_ERROR, "An (Errno %d) error has occurred" > + You should use error_setg() instead: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg04980.html There usage examples in the series introducing it. It would be better to wait for it to be merged before you use it though, as it's always possible for people to ask for changes. > #define QERR_INVALID_BLOCK_FORMAT \ > ERROR_CLASS_GENERIC_ERROR, "Invalid block format '%s'" >