From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T6zwO-0000u8-58
	for qemu-devel@nongnu.org; Thu, 30 Aug 2012 04:17:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T6zwI-0003SN-E0
	for qemu-devel@nongnu.org; Thu, 30 Aug 2012 04:17:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2655)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T6zwI-0003S8-5o
	for qemu-devel@nongnu.org; Thu, 30 Aug 2012 04:17:22 -0400
Date: Thu, 30 Aug 2012 10:17:10 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20120830101711.2b08ae6d@thinkpad.mammed.net>
In-Reply-To: <503F1943.8060007@redhat.com>
References: <1346259767-991-1-git-send-email-imammedo@redhat.com>
	<1346259767-991-2-git-send-email-imammedo@redhat.com>
	<503E4C25.3050102@suse.de>
	<20120830084945.3d8fd28d@thinkpad.mammed.net>
	<503F1943.8060007@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Thu, 30 Aug 2012 09:41:55 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 30/08/2012 08:49, Igor Mammedov ha scritto:
> >>> > > +static void qemu_system_powerdown(void)
> > this is a bad naming that conflicts with global var qemu_system_powerdown, so
> > bisectability of series is still broken.
> > perhaps qemu_do_system_powerdown() would be better for function name,
> > although it doesn't match common name pattern used for this kind of functions.
> > 
> 
> Just inline the function in this patch, and uninline it later.
Thanks, fixed in https://github.com/imammedo/qemu/tree/cpu_as_device.WIP
> 
> Paolo
> 


-- 
Regards,
  Igor