From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56744)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T748x-0006EO-3v
	for qemu-devel@nongnu.org; Thu, 30 Aug 2012 08:46:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T748r-0004SL-8N
	for qemu-devel@nongnu.org; Thu, 30 Aug 2012 08:46:43 -0400
Received: from paradis.irqsave.net ([109.190.18.76]:36231)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1T748r-0004RH-0O
	for qemu-devel@nongnu.org; Thu, 30 Aug 2012 08:46:37 -0400
Date: Thu, 30 Aug 2012 14:46:29 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20120830124629.GA3692@irqsave.net>
References: <1346051752-13551-1-git-send-email-benoit@irqsave.net>
	<503BB3FB.5060901@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <503BB3FB.5060901@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@gmail.com>, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com

Le Monday 27 Aug 2012 =E0 11:52:59 (-0600), Eric Blake a =E9crit :
> On 08/27/2012 01:15 AM, Beno=EEt Canet wrote:
> > This patchset add a JSON output mode to the qemu-img info command.
> > It's a rewrite from scratch of the original patchset by Wenchao Xia
> > following Anthony Liguori advices on JSON formating.
> >=20
> > the --output=3D(json|human) option is now mandatory on the command li=
ne.
>=20
> This statement is not true, but doesn't affect the series itself.
>=20
> > in v6:
> >=20
> > Blue Swirl: -Add missing const in getopt structure declaration.
> >=20
> > Eric Blake: -Remove spurious undef.
> >             -Use an enum instead of two boolean.
>=20
> You have now addressed my complaints about the interface, but I would
> feel comfortable if someone more familiar with qemu-img itself gives
> final review and/or ack.

gentle ping

Beno=EEt

>=20
> --=20
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20