From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T78K9-0006GS-3B for qemu-devel@nongnu.org; Thu, 30 Aug 2012 13:14:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T78K4-0006Ur-Cw for qemu-devel@nongnu.org; Thu, 30 Aug 2012 13:14:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T78K4-0006Uj-5G for qemu-devel@nongnu.org; Thu, 30 Aug 2012 13:14:28 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7UHERAQ020715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Aug 2012 13:14:27 -0400 Date: Thu, 30 Aug 2012 14:15:13 -0300 From: Luiz Capitulino Message-ID: <20120830141513.01fbf98b@doriath.home> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/18] qapi: Convert savevm, loadvm, delvm and info snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org On Wed, 15 Aug 2012 09:41:41 +0200 Pavel Hrdina wrote: > This patch series convert these commands into qapi and intruduce QMP commands > vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots. > It also rewrite error report for function used by these commands. Unfortunately, most of the error conversions are wrong. I've commented on them, but the most important thing here is to decide how we should propagate the Error object in the block layer and what to do with its errno usage. It's better to discuss this first before doing large changes. It might also be worth it to split this series and work on error propagation first. I've CC'ed the block layer guys in one of my reviews to this series.