From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9BEH-0001Z0-8X for qemu-devel@nongnu.org; Wed, 05 Sep 2012 04:45:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9BEB-000249-Av for qemu-devel@nongnu.org; Wed, 05 Sep 2012 04:44:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9BEB-000242-2r for qemu-devel@nongnu.org; Wed, 05 Sep 2012 04:44:51 -0400 Date: Wed, 5 Sep 2012 10:44:42 +0200 From: Igor Mammedov Message-ID: <20120905104442.778e46e7@nial.usersys.redhat.com> In-Reply-To: <1345226022-21654-2-git-send-email-ehabkost@redhat.com> References: <1345226022-21654-1-git-send-email-ehabkost@redhat.com> <1345226022-21654-2-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 1/6] x86_cpudef_setup: coding style change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, afaerber@suse.de On Fri, 17 Aug 2012 14:53:37 -0300 Eduardo Habkost wrote: > Make source code lines shorter. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 96ec9e6..519a104 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1500,20 +1500,23 @@ void x86_cpudef_setup(void) > static const char *model_with_versions[] = { "qemu32", "qemu64", > "athlon" }; > for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); ++i) { > - builtin_x86_defs[i].next = x86_defs; > - builtin_x86_defs[i].flags = 1; > + x86_def_t *def = &builtin_x86_defs[i]; > + def->next = x86_defs; > + def->flags = 1; > > /* Look for specific "cpudef" models that */ > /* have the QEMU version in .model_id */ > for (j = 0; j < ARRAY_SIZE(model_with_versions); j++) { > - if (strcmp(model_with_versions[j], builtin_x86_defs[i].name) > == 0) { > - pstrcpy(builtin_x86_defs[i].model_id, > sizeof(builtin_x86_defs[i].model_id), "QEMU Virtual CPU version "); > - pstrcat(builtin_x86_defs[i].model_id, > sizeof(builtin_x86_defs[i].model_id), qemu_get_version()); > + if (strcmp(model_with_versions[j], def->name) == 0) { > + pstrcpy(def->model_id, sizeof(def->model_id), > + "QEMU Virtual CPU version "); > + pstrcat(def->model_id, sizeof(def->model_id), > + qemu_get_version()); > break; > } > } > > - x86_defs = &builtin_x86_defs[i]; > + x86_defs = def; > } > #if !defined(CONFIG_USER_ONLY) > qemu_opts_foreach(qemu_find_opts("cpudef"), cpudef_register, NULL, 0); Reviewed-By: Igor Mammedov