From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9BHu-0003ef-FA for qemu-devel@nongnu.org; Wed, 05 Sep 2012 04:48:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9BHo-0003XI-PJ for qemu-devel@nongnu.org; Wed, 05 Sep 2012 04:48:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9BHo-0003XD-Gu for qemu-devel@nongnu.org; Wed, 05 Sep 2012 04:48:36 -0400 Date: Wed, 5 Sep 2012 10:48:28 +0200 From: Igor Mammedov Message-ID: <20120905104828.12aa57ea@nial.usersys.redhat.com> In-Reply-To: <1345226022-21654-4-git-send-email-ehabkost@redhat.com> References: <1345226022-21654-1-git-send-email-ehabkost@redhat.com> <1345226022-21654-4-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 3/6] i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, afaerber@suse.de On Fri, 17 Aug 2012 14:53:39 -0300 Eduardo Habkost wrote: > Bit 10 of CPUID[8000_0001].EDX is not defined as an alias of > CPUID[1].EDX[10], so do not duplicate it on > kvm_arch_get_supported_cpuid(). > > Signed-off-by: Eduardo Habkost > --- > target-i386/kvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 696b14a..bab1ef8 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -163,7 +163,7 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, > uint32_t function, > * so add missing bits according to the AMD spec: > */ > cpuid_1_edx = kvm_arch_get_supported_cpuid(s, 1, 0, > R_EDX); > - ret |= cpuid_1_edx & 0x183f7ff; > + ret |= cpuid_1_edx & 0x183f3ff; > break; > } > break; Reviewed-By: Igor Mammedov