From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T9E55-0007Mp-Ot
	for qemu-devel@nongnu.org; Wed, 05 Sep 2012 07:47:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T9E4z-00011D-VH
	for qemu-devel@nongnu.org; Wed, 05 Sep 2012 07:47:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65382)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T9E4z-000119-Mr
	for qemu-devel@nongnu.org; Wed, 05 Sep 2012 07:47:33 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q85BlWmZ000539
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 5 Sep 2012 07:47:32 -0400
Received: from nial.usersys.redhat.com (dhcp-1-247.brq.redhat.com
	[10.34.1.247])
	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id q85BlVVE027148
	for <qemu-devel@nongnu.org>; Wed, 5 Sep 2012 07:47:31 -0400
Date: Wed, 5 Sep 2012 13:47:30 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20120905134730.6da48739@nial.usersys.redhat.com>
In-Reply-To: <1345226022-21654-7-git-send-email-ehabkost@redhat.com>
References: <1345226022-21654-1-git-send-email-ehabkost@redhat.com>
	<1345226022-21654-7-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 6/6] i386: -cpu help: remove reference to
 specific CPUID leaves/registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, 17 Aug 2012 14:53:42 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> The -cpu configuration interface is based on a list of feature names or
> properties, on a single namespace, so there's no need to mention on
> which CPUID leaf/register each flag is located.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index a71c2fc..0a03c80 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1297,13 +1297,13 @@ void x86_cpu_list(FILE *f, fprintf_function
> cpu_fprintf) }
>      (*cpu_fprintf)(f, "\nRecognized CPUID flags:\n");
>      listflags(buf, sizeof(buf), (uint32_t)~0, feature_name, 1);
> -    (*cpu_fprintf)(f, "  f_edx: %s\n", buf);
> +    (*cpu_fprintf)(f, "  %s\n", buf);
>      listflags(buf, sizeof(buf), (uint32_t)~0, ext_feature_name, 1);
> -    (*cpu_fprintf)(f, "  f_ecx: %s\n", buf);
> +    (*cpu_fprintf)(f, "  %s\n", buf);
>      listflags(buf, sizeof(buf), (uint32_t)~0, ext2_feature_name, 1);
> -    (*cpu_fprintf)(f, "  extf_edx: %s\n", buf);
> +    (*cpu_fprintf)(f, "  %s\n", buf);
>      listflags(buf, sizeof(buf), (uint32_t)~0, ext3_feature_name, 1);
> -    (*cpu_fprintf)(f, "  extf_ecx: %s\n", buf);
> +    (*cpu_fprintf)(f, "  %s\n", buf);
>  }
>  
>  CpuDefinitionInfoList *qmp_query_cpu_definitions(Error **errp)

If you are removing this ones, why do you leave:
if (dump) {
...
(*cpu_fprintf)(f, "  feature_edx %08x (%s)\n", def->features,
....