Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Sep 06, 2012 at 10:44:15AM +0200, Jan Kiszka wrote:
> On 2012-08-30 20:30, Jan Kiszka wrote:
> > This adds PCI device assignment for i386 targets using the classic KVM
> > interfaces. This version is 100% identical to what is being maintained
> > in qemu-kvm for several years and is supported by libvirt as well. It is
> > expected to remain relevant for another couple of years until kernels
> > without full-features and performance-wise equivalent VFIO support are
> > obsolete.
> > 
> > A refactoring to-do that should be done in-tree is to model MSI and
> > MSI-X support via the generic PCI layer, similar to what VFIO is already
> > doing for MSI-X. This should improve the correctness and clean up the
> > code from duplicate logic.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > 
> > Changes in v3:
> >  - addressed comment by Peter (changed device name to kvm-pci-assign +
> >    alias)
> >  - addressed (most) comments by Michael
> >  - fixed INT pin regression
> 
> Does someone _disagree_ that there are no open (and reasonably solvable)
> issues and that this can now be merged through uq/master?
> 
> Jan

Ugh this thread was shamelessly highjacked by coding style
bike-shedding. I am guilty to.
In hopes of making amends:

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> -- 
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux