From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Xl4-0006L4-GE for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:48:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9Xkm-0004RV-4R for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:48:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Xkl-0004QM-Sd for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:48:00 -0400 Date: Thu, 6 Sep 2012 11:49:17 +0300 From: "Michael S. Tsirkin" Message-ID: <20120906084917.GG17656@redhat.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503CA542.7030707@siemens.com> <503FB128.4070709@siemens.com> <5048625F.2060706@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5048625F.2060706@siemens.com> Subject: Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Peter Maydell , kvm@vger.kernel.org, Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , Avi Kivity , Andreas =?iso-8859-1?Q?F=E4rber?= On Thu, Sep 06, 2012 at 10:44:15AM +0200, Jan Kiszka wrote: > On 2012-08-30 20:30, Jan Kiszka wrote: > > This adds PCI device assignment for i386 targets using the classic KVM > > interfaces. This version is 100% identical to what is being maintained > > in qemu-kvm for several years and is supported by libvirt as well. It is > > expected to remain relevant for another couple of years until kernels > > without full-features and performance-wise equivalent VFIO support are > > obsolete. > > > > A refactoring to-do that should be done in-tree is to model MSI and > > MSI-X support via the generic PCI layer, similar to what VFIO is already > > doing for MSI-X. This should improve the correctness and clean up the > > code from duplicate logic. > > > > Signed-off-by: Jan Kiszka > > --- > > > > Changes in v3: > > - addressed comment by Peter (changed device name to kvm-pci-assign + > > alias) > > - addressed (most) comments by Michael > > - fixed INT pin regression > > Does someone _disagree_ that there are no open (and reasonably solvable) > issues and that this can now be merged through uq/master? > > Jan Ugh this thread was shamelessly highjacked by coding style bike-shedding. I am guilty to. In hopes of making amends: Acked-by: Michael S. Tsirkin > -- > Siemens AG, Corporate Technology, CT RTC ITP SDP-DE > Corporate Competence Center Embedded Linux