From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59259)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1T9s6F-00042h-OR
	for qemu-devel@nongnu.org; Fri, 07 Sep 2012 02:31:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1T9s6B-0004vi-PX
	for qemu-devel@nongnu.org; Fri, 07 Sep 2012 02:31:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13038)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1T9s6B-0004vd-GT
	for qemu-devel@nongnu.org; Fri, 07 Sep 2012 02:31:27 -0400
Date: Fri, 7 Sep 2012 09:32:37 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120907063237.GA13651@redhat.com>
References: <1345582331-22593-1-git-send-email-nab@linux-iscsi.org>
	<20120907062322.GB9232@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120907062322.GB9232@redhat.com>
Subject: Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host
	virtualized target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, kvm-devel <kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, Zhi Yong Wu <wuzhy@cn.ibm.com>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, target-devel <target-devel@vger.kernel.org>, Hannes Reinecke <hare@suse.de>, Paolo Bonzini <pbonzini@redhat.com>, lf-virt <virtualization@lists.linux-foundation.org>, Christoph Hellwig <hch@lst.de>

On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote:
> On Tue, Aug 21, 2012 at 08:52:06PM +0000, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> > Hi folks,
> > 
> > This is the third RFC for vhost-scsi patches against mainline QEMU v1.1
> 
> I rebased on top of 1.2 and put this in my tree:
> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci
> 
> Please check it out, meanwhile we'll see if anyone complains.

OK I will be the first :).
Looks like build *without* CONFIG_VHOST_SCSI
is broken now:
 LINK  sparc64-softmmu/qemu-system-sparc64
../hw/qdev-properties.o: In function `parse_vhost_scsi_dev':
/scm/qemu/hw/qdev-properties.c:706: undefined reference to
`find_vhost_scsi'
../hw/qdev-properties.o: In function `print_vhost_scsi_dev':
/scm/qemu/hw/qdev-properties.c:719: undefined reference to
`vhost_scsi_get_id'
../libhw64/vl.o: In function `vhost_scsi_init_func':
/scm/qemu/vl.c:1943: undefined reference to `vhost_scsi_add_opts'
hw/virtio-scsi.o: In function `virtio_scsi_set_status':
/scm/qemu/hw/virtio-scsi.c:733: undefined reference to `vhost_scsi_stop'
/scm/qemu/hw/virtio-scsi.c:724: undefined reference to
`vhost_scsi_start'

Please add stubs *and test* without CONFIG_VHOST_SCSI.

While at it can we please rename file to vhost_scsi.c, vhost_scsi.h?
qemu is inconsistent but vhost files all use _ as separator:
this means function names and file names are in sync.

Reverted for now, waiting for v4.
Thanks!

> -- 
> MST