From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33739)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TBPHi-0008Pa-93
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 08:09:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TBPHb-0005dr-KU
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 08:09:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TBPHb-0005dl-CA
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 08:09:35 -0400
Date: Tue, 11 Sep 2012 09:10:23 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120911091023.04506977@doriath.home>
In-Reply-To: <CAGrFBsguek5zj_VOL16MF-7zv5shWnqYvfaK-0vLqQBHw19DVw@mail.gmail.com>
References: <1346901211-8314-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<87392u8brf.fsf@blackfin.pond.sub.org>
	<20120910143821.143c6f48@doriath.home>
	<CAGrFBsguek5zj_VOL16MF-7zv5shWnqYvfaK-0vLqQBHw19DVw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC] remove QEMUOptionParameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Tue, 11 Sep 2012 09:57:12 +0800
Dong Xu Wang <wdongxu@linux.vnet.ibm.com> wrote:

> >> >
> >> > -        set_option_parameter_int(options, BLOCK_OPT_SIZE, total_size);
> >> > -        set_option_parameter(options, BLOCK_OPT_BACKING_FILE, backing_filename);
> >> > +        snprintf(buf_total_size, sizeof(buf_total_size),
> >> > +            "%" PRId64, total_size);
> >> > +        qemu_opt_set(options, BLOCK_OPT_SIZE, buf_total_size);
> >>
> >> This is a bit awkward.
> >>
> >> We could have qemu_opt_set_number(), like qemu_opt_set_bool().  Except
> >> qemu_opt_set_bool() has issues.  Luiz's fix is discussed here:
> >> http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html
> >>
> >> Luiz, do you plan to respin?
> >
> > I'm not going to respin the whole series, but the patch you mention
> > and the following two seem worth it to have on master.
> >
> > Dong, do you want me to respin or can you add them to this series?
> 
> I can add them to this series,  thank you Luiz.

I just don't remember if there's anything to be addressed, so it's a good
idea to re-read the thread.