From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38074)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1TBdhX-0006hk-4d
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 23:33:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1TBdhW-0004KA-5h
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 23:33:19 -0400
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:58076)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1TBdhV-0004Jx-IE
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 23:33:18 -0400
Received: from /spool/local
	by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Wed, 12 Sep 2012 09:03:11 +0530
Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65])
	by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q8C3X8wm10027008
	for <qemu-devel@nongnu.org>; Wed, 12 Sep 2012 09:03:09 +0530
Received: from d28av03.in.ibm.com (loopback [127.0.0.1])
	by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q8C3X7Ux028749
	for <qemu-devel@nongnu.org>; Wed, 12 Sep 2012 13:33:08 +1000
Date: Wed, 12 Sep 2012 09:05:01 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20120912033501.GB13500@in.ibm.com>
References: <20120911082824.GA24816@in.ibm.com>
	<87k3w0pwla.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87k3w0pwla.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH v1] Make inet_parse() non-static
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Tue, Sep 11, 2012 at 02:34:09PM +0200, Markus Armbruster wrote:
> Bharata B Rao <bharata@linux.vnet.ibm.com> writes:
> 
> > From: Bharata B Rao <bharata@linux.vnet.ibm.com>
> >
> > Make inet_parse() non static.
> >
> > - Make inet_parse() non-static so that other subsystems like gluster
> >   can use it to parse inet addresses. As a pre-requisite, define and
> >   globalize the qemu_inet_opts.
> 
> Please repost this as part of a series that needs non-static
> inet_parse().

Sure, will post it as part of next version of gluster patches.

> I'm worried parameter "block" will cause trouble, but I
> can't see that without the users.

I don't see how that could affect the users. FYI I am not using "block"
parameter, pls wait for my next post to check this.

> 
> > - Extend inet_parse() to parse just 'address' also in addition to
> >  'address:port'.
> 
> Separate patch, please.

Hmm ok.

> 
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > ---
> > Ideally I needn't use sscanf twice once for parsing host:port (checking
> > return value of 2) and if that fails for parsing host w/o port (checking
> > return value of 1). I could just check if sscanf returned 2 or 1 and decide
> > if addr:port or just addr was provided, but in the latter case the
> > pointer to the bytes consumed (&pos) doesn't get updated.
> 
> You can use two of them, like this:
> 
>     a_end = b_end = -1;
>     sscanf(str, "%d%n:%d%n", &a, &a_end, &b, &b_end);
>     if (b_end >= 0) ...

Thanks.
Bharata.