From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBj7u-0001gP-KU for qemu-devel@nongnu.org; Wed, 12 Sep 2012 05:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBj7q-0008Pi-1R for qemu-devel@nongnu.org; Wed, 12 Sep 2012 05:20:54 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:47662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBj7p-0008PJ-2b for qemu-devel@nongnu.org; Wed, 12 Sep 2012 05:20:49 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Sep 2012 14:50:41 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8C9KR0d39256160 for ; Wed, 12 Sep 2012 14:50:28 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8C9KRNO022057 for ; Wed, 12 Sep 2012 19:20:27 +1000 Date: Wed, 12 Sep 2012 14:52:10 +0530 From: Bharata B Rao Message-ID: <20120912092210.GF13500@in.ibm.com> References: <20120814043801.GB24944@in.ibm.com> <502A0C66.3060107@redhat.com> <20120814093430.GE24944@in.ibm.com> <502A2140.9050703@redhat.com> <50485EF0.70505@redhat.com> <20120906154004.GB20421@in.ibm.com> <20120906154717.GI3077@redhat.com> <20120907032123.GC20421@in.ibm.com> <5049C014.8010305@redhat.com> <5049C526.20901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5049C526.20901@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Anthony Liguori , Anand Avati , Stefan Hajnoczi , Vijay Bellur , Amar Tumballi , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Paolo Bonzini On Fri, Sep 07, 2012 at 11:57:58AM +0200, Kevin Wolf wrote: > Am 07.09.2012 11:36, schrieb Paolo Bonzini: > > Hmm, why don't we do the exact same thing as libvirt (http://libvirt.org/remote.html): > > > > ipv4 - gluster+tcp://1.2.3.4:0/testvol/dir/a.img > > ipv6 - gluster+tcp://[1:2:3:4:5:6:7:8]:0/testvol/a.img > > host - gluster+tcp://example.org/testvol/dir/a.img > > unix - gluster+unix:///testvol/dir/a.img?socket=/tmp/glusterd.socket > > rdma - gluster+rdma://1.2.3.4:0/testvol/a.img > > > > Where the default transport is tcp (i.e. gluster+tcp is the same as gluster). > > This is easily extensible, theoretically you could have something like this: > > > > ssh - gluster+ssh://user@host/testvol/a.img?socket=/tmp/glusterd.socket > > I like this. Having the type only as a parameter when it decides how the > schema must be parsed has bothered me from the start, but I hadn't > thought of this way. > > Strong +1 from me. FYI, bdrv_find_protocol() fails for protocols like this. It detects the protocol as "gluster+tcp" and compares it with drv->protocol_name (which is only "gluster"). I guess I will have to fix bdrv_find_protocol() to handle the '+' within protocol string correctly. Regards, Bharata. > > Kevin