From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBtfV-0005Cg-R1 for qemu-devel@nongnu.org; Wed, 12 Sep 2012 16:36:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBtfU-0006fH-Ue for qemu-devel@nongnu.org; Wed, 12 Sep 2012 16:36:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBtfU-0006f9-Ln for qemu-devel@nongnu.org; Wed, 12 Sep 2012 16:36:16 -0400 Date: Wed, 12 Sep 2012 23:37:40 +0300 From: "Michael S. Tsirkin" Message-ID: <20120912203740.GA1163@redhat.com> References: <1347448378-23915-1-git-send-email-owasserm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1347448378-23915-1-git-send-email-owasserm@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/3] nonblocking connect address handling cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: kwolf@redhat.com, aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com, quintela@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, akong@redhat.com On Wed, Sep 12, 2012 at 02:12:55PM +0300, Orit Wasserman wrote: > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actually working. > A simple way to reproduce the problem is migration: > for the destination use -incoming tcp:0:4444, run migrate -d tcp:localhost:4444 > migration will fail on hosts that have both IPv4 and IPV6 address for localhost. > > To fix this, refactor address resolution code and make inet_nonblocking_connect > retry connection with a different address. Nice improvement over my patch. thanks For the series: Acked-by: Michael S. Tsirkin Anthony, we got reports offlist from people with such setups - migration under 1.2 regressed for them. So I think we need this on 1.2.X as well if this ever happens. > Orit Wasserman (3): > Refactor inet_connect_opts function > Separate inet_connect into inet_connect (blocking) and > inet_nonblocking_connect > Fix address handling in inet_nonblocking_connect > > migration-tcp.c | 29 ++----- > nbd.c | 2 +- > qemu-sockets.c | 254 +++++++++++++++++++++++++++++++++++++++++-------------- > qemu_socket.h | 9 ++- > ui/vnc.c | 2 +- > 5 files changed, 208 insertions(+), 88 deletions(-) > > -- > 1.7.7.6