From: "Michael S. Tsirkin" <mst@redhat.com>
To: Orit Wasserman <owasserm@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com,
quintela@redhat.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com, Markus Armbruster <armbru@redhat.com>,
pbonzini@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function
Date: Fri, 14 Sep 2012 10:37:47 +0300 [thread overview]
Message-ID: <20120914073747.GG7916@redhat.com> (raw)
In-Reply-To: <50520F53.5000903@redhat.com>
On Thu, Sep 13, 2012 at 07:52:35PM +0300, Orit Wasserman wrote:
> >> + for (e = res; e != NULL; e = e->ai_next) {
> >> + sock = inet_connect_addr(e, block, in_progress, errp);
> >> + if (in_progress && *in_progress) {
> >> + return sock;
> >
> > Doesn't this leak res?
> Actually it doesn't after patch 3 wait_for_connect is the one freeing res.
> is it OK to leave it as is ?
>
> Orit
We can't avoid breaking bisect sometimes but let's not do this intentionally.
--
MST
next prev parent reply other threads:[~2012-09-14 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 11:12 [Qemu-devel] [PATCH v2 0/3] nonblocking connect address handling cleanup Orit Wasserman
2012-09-12 11:12 ` [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function Orit Wasserman
2012-09-13 12:35 ` Markus Armbruster
2012-09-13 16:44 ` Orit Wasserman
2012-09-13 16:52 ` Orit Wasserman
2012-09-14 7:37 ` Michael S. Tsirkin [this message]
2012-09-13 13:14 ` Markus Armbruster
2012-09-13 16:44 ` Orit Wasserman
2012-09-12 11:12 ` [Qemu-devel] [PATCH v2 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect Orit Wasserman
2012-09-13 12:44 ` Markus Armbruster
2012-09-13 16:40 ` Orit Wasserman
2012-09-12 11:12 ` [Qemu-devel] [PATCH v2 3/3] Fix address handling in inet_nonblocking_connect Orit Wasserman
2012-09-13 13:22 ` Markus Armbruster
2012-09-13 13:32 ` Michael S. Tsirkin
2012-09-13 14:23 ` Orit Wasserman
2012-09-13 17:27 ` Orit Wasserman
2012-09-12 14:16 ` [Qemu-devel] [PATCH v2 0/3] nonblocking connect address handling cleanup Amos Kong
2012-09-12 20:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914073747.GG7916@redhat.com \
--to=mst@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).